refactor(observers): Meter (revert AvgMeter) + string-secured reduction=#15
Merged
Conversation
…tion=
Revert the AvgMeter rename back to Meter -- it is the family base
(TimingMeter / MemoryMeter / CPUMeter / MetricsMeter are Meters) -- and make
the aggregation configurable instead of hardcoded "average":
- Meter(name=None, *, reduction="mean"): reduction is a validated STRING
("mean"/"max"/"min"/"sum"/"last"/"count"; unknown -> ValueError) mapped to
an internal reducer in the REDUCTIONS registry (callers pass a name, not a
raw callable).
- State accumulates sum/count/max/min/last; .value reduces it; .reduction
exposes the name; stats == {value, count} (was {val, avg, sum, count}).
- Concrete meters pass an overridable default: TimingMeter "mean",
MemoryMeter "max" (peak), CPUMeter "mean", MetricsMeter "mean".
- tests: new reduction tests (max, unknown->ValueError); stats assertions
updated to {value, count}; a call-counter via reduction="sum".
- docs (README, observers.md, task.md) + examples/03 + agent file migrated
off the old val/avg/sum stats and "running average" language.
mypy strict 0, ruff + format clean, 183 passed / 3 skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts AvgMeter -> Meter (the family base) and replaces hardcoded averaging with a validated reduction= string ('mean'/'max'/'min'/'sum'/'last'/'count'; unknown raises ValueError) mapped to an internal reducer. stats is now {value, count}; .value/.reduction expose the result. Concrete meters pass an overridable default (TimingMeter mean, MemoryMeter max, CPUMeter mean, MetricsMeter mean). Tests, README, docs/observers.md, docs/task.md, examples/03 and the agent file all migrated off the old val/avg/sum stats. mypy strict 0, ruff+format clean, 183 passed / 3 skipped.