SCIX-877 feat(metatags): gate Google Scholar tags by doctype#883
Open
thostetler wants to merge 1 commit into
Open
SCIX-877 feat(metatags): gate Google Scholar tags by doctype#883thostetler wants to merge 1 commit into
thostetler wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #883 +/- ##
========================================
+ Coverage 61.2% 61.2% +0.1%
========================================
Files 348 349 +1
Lines 41373 41430 +57
Branches 1826 1808 -18
========================================
+ Hits 25297 25353 +56
- Misses 16033 16034 +1
Partials 43 43
🚀 New features to boost your workflow:
|
Only an allowed whitelist of doctypes emits Google Scholar-compatible meta tags (Highwire citation_*, PRISM prism.*, Dublin Core dc.*) on the abstract page. Other or unknown doctypes omit them; Schema.org JSON-LD, Open Graph, Twitter, canonical, and description tags remain for all records. Doctype comparisons are normalized to lowercase.
59c406c to
91e13d0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Risk summary: Low risk. Change is isolated to meta tag emission logic on abstract pages, with unit tests added/updated to cover allowed/blocked/missing/case-insensitive doctypes.
This PR implements SCIX-877 by gating Google Scholar–compatible meta tags (Highwire citation_*, PRISM prism.*, and Dublin Core dc.*) behind a doctype whitelist, while keeping Schema.org JSON-LD and general social/meta tags emitted for all records.
Changes:
- Added a centralized doctype whitelist and a case-insensitive
showsGoogleScholarTagspredicate. - Wrapped Highwire/PRISM/Dublin Core meta tag emission in
Metatagsbehind the new predicate and normalized legacy doctype comparisons to lowercase. - Added/updated unit tests to verify tag gating for whitelisted, removed, unlisted, missing, and case-variant doctypes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/components/Metatags/scholarDoctypes.ts |
Introduces the Google Scholar doctype whitelist and showsGoogleScholarTags() helper. |
src/components/Metatags/Metatags.tsx |
Gates Highwire/PRISM/DC meta tags behind the whitelist; keeps JSON-LD and other tags always-on. |
src/components/Metatags/__tests__/Metatags.test.tsx |
Adds test coverage for doctype gating, including case-insensitive matching and missing doctypes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Scholar-compatible meta tags were emitted on every abstract page regardless of doctype. Per SCIX-877 only a defined set of doctypes should expose them; non-scholarly doctypes (proposal, dataset, software, misc, pressrelease, catalog, talk, service, instrument) should not.