SCIX-876 Change UAT facet to use uat field instead of uat_facet_hier#885
SCIX-876 Change UAT facet to use uat field instead of uat_facet_hier#885thostetler wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #885 +/- ##
========================================
- Coverage 61.2% 61.2% -0.0%
========================================
Files 349 349
Lines 41439 41437 -2
Branches 1836 1836
========================================
- Hits 25359 25357 -2
Misses 16037 16037
Partials 43 43
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Search Facet configuration so the UAT facet queries the flat uat field instead of the hierarchical uat_facet_hier, aligning the facet behavior with the intended Solr field.
Changes:
- Switched the UAT facet config from
uat_facet_hiertouatand removed hierarchical-only settings. - Extended the
FacetFieldunion type and facet field list to includeuat. - Updated facet-related mocks and removed
fq_uatfrom the hierarchicalcleanClausebranch.
Risk summary: Low functional risk to production search behavior (mostly config/type wiring), but there is a moderate-risk inconsistency in the MSW facet mock generator that can make UAT facet prefix filtering behave unrealistically in tests/dev.
Findings (priority order)
- medium (bug) — Mock facet generator ignores
prefixforuat- Impact: When the UI requests facet data with a prefix (letter/search filtering), MSW-generated UAT buckets won’t reflect that prefix, making mocked behavior inconsistent with real Solr behavior and potentially weakening/undermining UI tests that rely on prefix filtering.
- Location:
src/mocks/generators/facets.ts:23-24 - Minimal fix: Apply the provided
prefixwhen generatinguatvalues (inline suggestion provided in PR comment). - Confidence: high
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/mocks/generators/facets.ts | Updates mock facet bucket value generation for uat. |
| src/components/SearchFacet/types.ts | Switches facet field list entry from uat_facet_hier to uat. |
| src/components/SearchFacet/helpers.ts | Removes fq_uat from hierarchical clause-cleaning behavior. |
| src/components/SearchFacet/config.ts | Updates UAT facet config to use uat and removes hierarchical-only settings. |
| src/components/mocks/facetCountFields.ts | Adds uat to mocked facet_fields. |
| src/api/search/types.ts | Extends FacetField type to include uat. |
015c739 to
7176dc9
Compare
Changes the UAT search facet to query the uat field instead of uat_facet_hier.