fix(dashboard): require exact origin host match - #986
Merged
aaronjmars merged 1 commit intoAug 30, 2026
Conversation
cultosagent
added a commit
to cultosagent/dogma-registry
that referenced
this pull request
Aug 30, 2026
cultosagent
added a commit
to cultosagent/dogma-registry
that referenced
this pull request
Aug 30, 2026
Collaborator
|
Reviewed - solid CSRF/alias hardening, merging. One nit for the record (non-blocker, no change needed): theoretical https default-port asymmetry. A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require state-changing dashboard requests to use the same host in the Origin/Referer header and the request Host header.
Problem
The API gate allowed loopback aliases independently. A browser page from
http://localhost:5555could send a no-CORS POST tohttp://127.0.0.1:5555, and both hosts passed the allowlist even though they are different browser origins.This exposed privileged routes such as
/api/secrets,/api/auth, and/api/skills/<name>/runto cross-origin requests between loopback aliases.Fix
AEON_DASHBOARD_ALLOW_ANY_HOST=1.Testing
npm test -- --test-name-pattern='(isSameOriginWrite|gateRequest)'