Upgrade PHP 8.5#2258
Open
stakovicz wants to merge 11 commits into
Open
Conversation
added 11 commits
May 25, 2026 21:30
Mopolo
reviewed
May 28, 2026
Contributor
Mopolo
left a comment
Mopolo
left a comment
There was a problem hiding this comment.
Un peu long à lire mais pas si compliqué en vrai. La majorité des modifs sont simples.
| @@ -43,8 +43,6 @@ public function clearEmails(): void | |||
| if (curl_errno($ch) !== 0) { | |||
| throw new \RuntimeException('Error : ' . curl_error($ch)); | |||
| } | |||
|
|
|||
| curl_close($ch); | |||
Contributor
There was a problem hiding this comment.
C'est plus nécessaire du tout ?
| throw new ExpectationException( | ||
| sprintf('The content "%s" was not found in the content "%s"', $expectedContent, $pageContent), | ||
| $this->minkContext->getSession()->getDriver(), | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| #[Then('print the page :page of the PDF')] | ||
| public function thePrint(string $page): void |
Contributor
There was a problem hiding this comment.
Elle ne semble pas utilisée cette nouvelle phrase.
| @@ -42,6 +42,7 @@ public function iParseThePdfContent(): void | |||
| public function thePageOfThePdfShouldContain(string $page, string $expectedContent): void | |||
| { | |||
| $pageContent = $this->pdfPages[$page] ?? null; | |||
| $pageContent = str_replace("\t", " ", $pageContent); | |||
Contributor
There was a problem hiding this comment.
À cause de la maj de la lib pdf je suppose ?
| @@ -45,8 +45,8 @@ Feature: Administration - Évènements - Factures d'évènement | |||
| When I parse the pdf downloaded content | |||
| Then The page "1" of the PDF should contain "Objet : Facture n°REF-TEST-003" | |||
| Then The page "1" of the PDF should contain "3 avenue de l'enterprise" | |||
| Then The page "1" of the PDF should contain "Type Personne inscrite Prix HT TVA Prix TTC" | |||
| Then The page "1" of the PDF should contain "2 Jours James Tiberius Kirk 227,27 € 10% 250,00 €" | |||
| Then The page "1" of the PDF should contain "Type Personne inscrite Prix HTT" | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Then The page "1" of the PDF should contain "Type Personne inscrite Prix HTT" | |
| Then The page "1" of the PDF should contain "Type Personne inscrite Prix HT" |
| Then The page "1" of the PDF should contain "Comme convenu, nous vous prions de trouver votre facture" | ||
| Then The page "1" of the PDF should contain "Type Description Quantite TVA Prix HT Total TTC" | ||
| Then The page "1" of the PDF should contain "forum_php_2025 Forum PHP 2025 - Sponsoring" | ||
| Then The page "1" of the PDF should contain "Bronze 1.00 20.00% 1 000,00 € 1 200,00 €" |
Contributor
There was a problem hiding this comment.
Comment ça se fait qu'on ne check plus ce genre de chose ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On met à jour PHP 8.5.
J'ai essayé de faire des commits atomic, mais c'est pas évident.
J'ai passé un coup de Rector et j'ai du adapter quelques tests à cause de la montée de version de
smalot/pdfparser