fix: invert KDE portal discrete vertical scroll polarity (#56)#57
Open
avifenesh wants to merge 1 commit into
Open
fix: invert KDE portal discrete vertical scroll polarity (#56)#57avifenesh wants to merge 1 commit into
avifenesh wants to merge 1 commit into
Conversation
xdg-desktop-portal-kde forwards NotifyPointerAxisDiscrete steps without the vertical negation used on its continuous path, so direction up/down was inverted on Plasma Wayland while ydotool REL_WHEEL stayed correct. Detect KDE/Plasma and invert vertical portal steps only; leave horizontal and the ydotool backend unchanged. Allow COMPUTER_USE_LINUX_PORTAL_SCROLL_INVERT to force either polarity.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scrollvia the XDG RemoteDesktop portal inverted vertical direction (downscrolled up and vice versa).xdg-desktop-portal-kdepasses discrete axis steps through without the vertical negation applied on its continuous path. Our portal mapping matched ydotool/REL_WHEELsigns, which is correct for GNOME/generic and for the ydotool fallback — but wrong for KDE discrete.XDG_CURRENT_DESKTOP/DESKTOP_SESSION) and invert vertical only portal discrete steps. Horizontal and ydotool are unchanged.COMPUTER_USE_LINUX_PORTAL_SCROLL_INVERT=0|1(also true/false/yes/no/on/off).Test plan
cargo test --lib remote_desktopCOMPUTER_USE_LINUX_FORCE_PORTAL_POINTER=1:scrolldown then up moves viewport as namedCloses #56