Add status fields to Substrate resources - #1025
Draft
Julian Gutierrez Oschmann (juli4n) wants to merge 3 commits into
Draft
Add status fields to Substrate resources#1025Julian Gutierrez Oschmann (juli4n) wants to merge 3 commits into
status fields to Substrate resources#1025Julian Gutierrez Oschmann (juli4n) wants to merge 3 commits into
Conversation
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
status_field
branch
from
August 17, 2026 22:03
2864483 to
9dd365f
Compare
Collaborator
|
Nevermind, I see.
|
Tim Hockin (thockin)
left a comment
Tim Hockin (thockin)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM overall - as you said "mechanical"
| // once at creation and immutable afterward. | ||
| ObjectRef source_snapshot_tag = 6; | ||
|
|
||
| ActorStatus status = 7; |
Collaborator
There was a problem hiding this comment.
Should we give status a high tag number (e.g. 1024)? Presumably we are going to add more fields in these resources. ISTR the tags are encoded as varint, so that has some downside...
| } | ||
|
|
||
| message ActorStatus { | ||
| enum State { |
Collaborator
There was a problem hiding this comment.
Aside: the resulting Go names for these are awful - WDYT about moving this to a file-level ActorState ?
| string actor_template_uid = 7; | ||
| SnapshotContentScope content_scope = 8; | ||
| string snapshot_uri = 9; | ||
| // Immutable reference to the actor_template_version where the snapshot was created from. |
Collaborator
There was a problem hiding this comment.
You lost the only comment in this whole section
| 3. **Hydration**: The `atelet` supervisor coordinates with the `ateom` process inside the worker pod to restore the ActorTemplate's golden `ActorSnapshot` (for first-run) or the Actor's latest `ActorSnapshot` (for recurring runs) into the sandbox. | ||
|
|
||
| 4. **Status**: Status transitions to `STATUS_RUNNING`. The actor now has an | ||
| 4. **Status**: Status transitions to `STATE_RUNNING`. The actor now has an |
| if actor.Status != ateapipb.Actor_STATUS_SUSPENDED { | ||
| t.Errorf("expected actor status to be SUSPENDED, got %v", actor.Status) | ||
| if actor.Status.State != ateapipb.ActorStatus_STATE_SUSPENDED { | ||
| t.Errorf("expected actor status to be SUSPENDED, got %v", actor.Status.State) |
Collaborator
There was a problem hiding this comment.
state
I found a few of these, I am sure it's not all of them. Maybe git grep -i 'actor.*status' and see what hits?
| 3. **Reclaim**: The physical worker is wiped and returned to the `WorkerPool`. | ||
|
|
||
| 4. **Status**: Status transitions back to `STATUS_SUSPENDED`, now pointing to | ||
| 4. **Status**: Status transitions back to `STATE_SUSPENDED`, now pointing to |
| // phase string the UI's badge logic understands (running / suspended | ||
| // / etc). | ||
| func actorStatusString(s ateapipb.Actor_Status) string { | ||
| func actorStatusString(s ateapipb.ActorStatus_State) string { |
Collaborator
There was a problem hiding this comment.
actorStateString
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
statusfields to all Substrate resources that need it. Move server-owned fields under it. SkipActorTemplateandActorTemplateVersionas those are still in-flux.Partially fixes #1006 .