Enable CSI support for micro-vm - #840
Open
hajiler wants to merge 1 commit into
Open
Conversation
hajiler
commented
Aug 11, 2026
| } | ||
| } | ||
| isDataScope := req.GetScope() == ateletpb.SnapshotScope_SNAPSHOT_SCOPE_DATA | ||
| if isDataScope && hasCsi && !hasDurable { |
Collaborator
Author
There was a problem hiding this comment.
Currently, we do not snapshot csi volumes since they are external and persisted beyond pause/suspend. So we are basically quitely ignoring Data snapshot config when only CSI volumes are present.
Instead should we either:
- Disallow Data scope snapshot when only CSI volumes are present?
- Take snapshots of CSI volumes?
- Add some additional scope specific to CSI volumes?
IMO maybe we just add a note to the the Data snapshot scope that it is particular to durable dir, and external volumes will not be snapshotted.
Collaborator
There was a problem hiding this comment.
I think that's correct for now. Dmitry Berkovich (@dberkov) FYI.
| } | ||
| } | ||
| isDataScope := req.GetScope() == ateletpb.SnapshotScope_SNAPSHOT_SCOPE_DATA | ||
| if isDataScope && hasCsi && !hasDurable { |
Collaborator
There was a problem hiding this comment.
I think that's correct for now. Dmitry Berkovich (@dberkov) FYI.
Collaborator
|
[needs rebase] |
hajiler
force-pushed
the
uvm
branch
6 times, most recently
from
August 17, 2026 23:32
8fa8f0f to
46df5c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for external volumes for micro vm environments.
This PR adds a new virtiofs specifically for CSI volume mounts.
Fixes #232