atunnel: ingress CONNECT support - #993
Open
Keith Mattix II (keithmattix) wants to merge 7 commits into
Open
Conversation
Keith Mattix II (keithmattix)
force-pushed
the
atunnel-ingress-connect
branch
from
August 17, 2026 18:40
f9e4121 to
d216b54
Compare
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Keith Mattix II (keithmattix)
force-pushed
the
atunnel-ingress-connect
branch
from
August 18, 2026 03:49
d85d3f0 to
165454a
Compare
| @@ -78,6 +78,7 @@ func buildDeploymentApplyConfig(wp *atev1alpha1.WorkerPool, otel ateomOTelSettin | |||
| WithArgs( | |||
| "--pod-uid=$(POD_UID)", | |||
| "--atunnel-listen-address=0.0.0.0:443", | |||
Collaborator
There was a problem hiding this comment.
Do we even need another listen address? Can't we serve everything here?
Collaborator
Author
There was a problem hiding this comment.
The logic for doing CONNECT from atenet router - > atunnel is non-trivial and it has some connection pooling implications, so I wanted to start with a separate port to keep the scope of this down. Doing it this way also helps us keep a baseline of current state around for a bit so we can make sure we don't regress by accident
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes up the vision from #715 to have atunnel serve CONNECT on the ingress path. This will give us the option to hit actors on other ports besides 80. I haven't wired up atenet router yet because it's nontrivial; we should do that in a second step so we can have a baseline for performance