Skip to content

build: add publish-readiness gates - #24

Merged
somus merged 3 commits into
mainfrom
somus/atf-27-publish-readiness
Jun 16, 2026
Merged

build: add publish-readiness gates#24
somus merged 3 commits into
mainfrom
somus/atf-27-publish-readiness

Conversation

@somus

@somus somus commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Summary

  • Add Changesets config and changeset intent for independent public package versioning.
  • Add packed-package publish-readiness checks with Bun packing, publint, and ATTW.
  • Add solo-workflow pkg.pr.new preview packages for same-repo PR updates.
  • Normalize publish metadata and keep source-schema JSON export contracts intact.

Related Issue

Public Impact

  • No public contract change
  • Spec or schema change
  • Public package API change
  • Changeset added or explicitly not needed
  • CLI behavior change
  • Public URL or docs behavior change

Impact description:

  • No TypeScript runtime API changes.
  • Public npm package metadata changes are intentional.
  • PR CI now enforces changeset status and packed package publish-readiness.
  • Same-repo PRs publish pkg.pr.new preview packages for testing before npm release.

Verification

  • bun test tests/check-publish-readiness.test.ts packages/source-schemas/type-smoke.test.ts packages/adapter-kit/src/source-schemas/tests/validate.test.ts: passed
  • bun run check:types: passed
  • bun run check:source-types: passed
  • bun run check:publish: passed
  • mise run check:actions: passed
  • mise run check: passed
  • GitHub guardrails: passed
  • GitHub preview: passed
  • GitHub Continuous Releases: passed

Reviewer Notes

  • No npm publish automation or npm token was added.
  • pkg.pr.new is intentionally limited to same-repo PRs for this solo workflow.
  • ATTW runs for typed JSON asset packages with a scoped false-export-default ignore so existing JSON import-attribute subpaths stay compatible.

@kody-ai

This comment has been minimized.

@stage-review

stage-review Bot commented Jun 16, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 6 individual chapters for you:

Title
1 Fix type exports in @agent-trail/types
2 Update package metadata and repository URLs
3 Implement publish-readiness validation script
4 Configure changesets for release management
5 Integrate publish gates into CI workflows
6 Other changes
Open in Stage

Chapters generated by Stage for commit e937803 on Jun 16, 2026 6:00am UTC.

@pkg-pr-new

pkg-pr-new Bot commented Jun 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@agent-trail/adapter-kit

bun add https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/adapter-kit@24
npm i https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/adapter-kit@24

@agent-trail/adapters

bun add https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/adapters@24
npm i https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/adapters@24

@agent-trail/catalog

bun add https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/catalog@24
npm i https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/catalog@24

@agent-trail/core

bun add https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/core@24
npm i https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/core@24

@agent-trail/redact

bun add https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/redact@24
npm i https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/redact@24

@agent-trail/render-model

bun add https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/render-model@24
npm i https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/render-model@24

@agent-trail/schema

bun add https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/schema@24
npm i https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/schema@24

@agent-trail/sessions

bun add https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/sessions@24
npm i https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/sessions@24

@agent-trail/source-schemas

bun add https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/source-schemas@24
npm i https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/source-schemas@24

@agent-trail/store

bun add https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/store@24
npm i https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/store@24

@agent-trail/types

bun add https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/types@24
npm i https://pkg.pr.new/agent-trail/typescript-sdk/@agent-trail/types@24

commit: e937803

Comment thread scripts/check-publish-readiness.ts
@kody-ai

kody-ai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@kody-ai

kody-ai Bot commented Jun 16, 2026

Copy link
Copy Markdown

kody code-review Kody Rules medium

Violation of 'Enforce pre-commit checks and PR standards' occurs because the PR description lacks a Linear issue link, an explicit impact statement, and verification commands with results required by AGENTS.md.

@kody-ai

kody-ai Bot commented Jun 16, 2026

Copy link
Copy Markdown

kody code-review Kody Rules medium

Non-compliance with 'Follow Pull Request Standards' results from omitting the .github/PULL_REQUEST_TEMPLATE.md requirements, specifically a linked Linear issue, a clearly stated impact section, and verification results.

@somus

somus commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Review Loop Closeout

Status: REVIEW_CLEAN
Base reviewed: origin/main (12b574104d8e9d92086424cff2bca0e55b7354de)
Rounds: 3/3
Pushed commit: e937803 - review: fix CI check ordering

Reviewer Results

Lens Accepted blockers Notes
Correctness / API 2 Fixed ATTW typed subpath coverage and preserved source-schema JSON subpath contract.
Security / Boundaries 0 Solo same-repo pkg.pr.new policy accepted.
Architecture / Maintainability 0 No final blockers.
Verification / Tests 2 Fixed preview Bun packing and CI build-before-test ordering.
UX / Docs 0 Nonblocking docs/package-page suggestions deferred.

Verification

Command Result
bun test tests/check-publish-readiness.test.ts packages/source-schemas/type-smoke.test.ts packages/adapter-kit/src/source-schemas/tests/validate.test.ts Passed
bun run check:types Passed
bun run check:source-types Passed
bun run check:publish Passed
mise run check:actions Passed
mise run check Passed

CI / Checks

Check Result
guardrails Passed
preview Passed
Continuous Releases Passed

External Reviewer Follow-up

Source Action Result
kody-ai PR standards comments Updated PR body with template structure, Linear link, public impact, and verification results. Addressed
pkg-pr-new Published preview package links. Passed
stage-review Generated review chapters. Informational

Fixes Applied

  • ATTW now scans typed export subpaths, not only root type entrypoints.
  • Source-schema JSON export subpaths remain JSON assets; ATTW gets a scoped false-export-default ignore only for typed JSON-backed exports.
  • pkg.pr.new preview publishing now uses Bun packing and Bun/npm install links.
  • Guardrails installs dependencies before changeset status.
  • Root check builds declarations before tests to avoid fresh-runner package-export races.

Final sentinel: REVIEW_CLEAN

@somus

somus commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Review-loop addendum: ran a final narrow pass after the CI check-ordering fix. Correctness/API and verification/architecture reviewers both returned no findings. Local mise run check and GitHub checks remain green.\n\nFinal sentinel: REVIEW_CLEAN

@somus
somus merged commit d8b8f1f into main Jun 16, 2026
3 checks passed
@somus
somus deleted the somus/atf-27-publish-readiness branch June 16, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant