fix(deps): floor cmcp-runtime so an unsatisfiable constraint fails loudly - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmcp-runtimehad no version floor, so an unsatisfiable constraint elsewhere in this file resolved as a silent three-version downgrade instead of an error.What happened
#48 bumps
weight-custody-manifestto>=0.25.0. That release requirescryptography>=50,<51.cmcp-runtime 0.4.0requiresagent-governance-toolkit-core>=4.1.0,<5.0, and every agt-core in that range capscryptography<49.0. The two cannot both be satisfied.Because
cmcp-runtimewas completely unpinned, pip did not say so. It backtracked tocmcp-runtime 0.1.0, the only release with no agt-core dependency at all, installed it andcryptography 50.0.0successfully, and the failure surfaced one step later as:Install exit code 0. The demo job then failed for what reads like a runtime bug in the gateway.
What this changes
cmcp-runtime>=0.4.0. The floor is the actual fix. With it, an unsatisfiable set is a resolver error naming the conflicting requirements, at install time, instead of an ancient runtime that starts and dies. That property matters more than this particular bump: any future dependency that caps cryptography low would have produced the same silent downgrade.weight-custody-manifest>=0.23.0,<0.25.0. A hold, not a preference. With the floor in place and no ceiling here, the demo simply stops installing. This keeps it working until the cap moves.Why the ceiling cannot just be dropped
Widening
cmcp-runtime's agt-core range does not help: agt-core 5.0.0 moves the cap only tocryptography<50.0, which still excludes the>=50that weight-custody-manifest 0.25.0 requires. There is no combination available today. The durable fix is upstream, in agt-core allowing cryptography 50, which is what agentrust-io/cmcp#471 is about.Remove the ceiling and unblock #48 once that lands.
Note on scope
examplesis not affected and needs no equivalent change. It carriescmcp-runtime>=0.4.0inindustrial-embodied-ai/requirements.txtandweight-custody-manifest>=0.25.0inweight-custody-manifest/requirements.txt, which are separate environments and never resolved together.demosresolves everything into one.