Skip to content

[FEATURE] Descriptive commit messages ... always? #1085

Description

@mlawren

Is your feature request related to a problem? Please describe.

I occasionally review the Git log to see what changed where. The pass CLI writes commit messages that a) use my name and email address, and b) describe how the change was made to what. For example:

commit 359744374a1c2be4a866c825a19aa03fc232933d
Author: Mark Lawrence <mark@my.domain>
Date:   Fri Aug 21 10:12:59 2026 +0200

    Add password for some.host using /usr/bin/vim.

The commit from APS on the other hand is less informative:

commit 510e2b9e9d9db22e98f7f2997e0228945421d66c
Author: root <localhost>
Date:   Fri Sep 11 08:53:51 2026 +0200

    [Android Password Store] Sync

As I was writing this issue I began to wonder what the two different save icons actually do. So I made another edit and hit the other one. This time I got a better commit message.

commit 455672556091892f11d80a328797ec46275bf421
Author: root <localhost>
Date:   Fri Sep 11 09:13:19 2026 +0200

    Password some.domain edited using Android Password Store

So I actually have two minor issues:

  1. I don't understand the difference between the two save icons. Where is that described, and could there be better way of displaying those actions?
  2. The Author field in Git commits is sometimes not so useful.

I get that this is two issues in one... I'll split them if you consider either one worthwhile investigating.

Describe the solution you'd like

For the save action(s), perhaps there could just be one icon, that pops up a two-item menu with words describing what they do?

For the commit, does APS have access to something like the device account name? Device model?

Author: $NAME <Android-Password-Store@$DEVICE_MODEL>

Describe alternatives you've considered

No alternatives available.

Additional context

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions