fix: don't reject accounts linked to a third-party provider - #8
Merged
Merged
Conversation
sign-in/code/verify has no dependency on how the account was originally created (Google, GitHub, password) — it authorizes purely on proof of email ownership via the emailed code, confirmed by reading the backend handler. The blanket rejection for any checkAccount().provider was an unfounded assumption on my part: OpenClaude's own onboarding UI never branches on that field either, it only looks at `action`. Removed the rejection so Google/GitHub-linked accounts can sign in through the same code flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`sign-in/code/verify` has no dependency on how the account was originally created (Google, GitHub, password) — confirmed by reading the backend handler (`apps/app/auth/src/controllers/v1/auth.controller.ts`): it authorizes purely on proof of email ownership via the emailed code, looking the user up by email/code alone.
The blanket rejection I added for any `checkAccount().provider` was an unfounded assumption — OpenClaude's own onboarding UI (`ProviderManager.tsx`) never branches on that field, only on `action`. Removed the rejection so Google/GitHub-linked accounts can sign in through the same code flow instead of being told to create a key manually.
Test plan