Fix package publishing skipped on tagged builds - #2
Merged
Conversation
The endjin pipeline publish phase has `needs: postCompile`, and the post-compile phase only runs when postCompilePhaseTasks is set. With it unset the phase is skipped, which cascades to skip publish on tagged builds. Point postCompilePhaseTasks at a no-op InvokeBuild task (NoOp, added to .zf/config.ps1) so the phase runs and publish is no longer skipped. Mirrors the fix applied to the Ais.Net.Models repo. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q3BkmohCNRYGY1RBKbNaCx
There was a problem hiding this comment.
Pull request overview
Ensures tagged builds publish packages by preventing the Endjin reusable pipeline’s publish phase from being skipped when the post-compile phase would otherwise be omitted.
Changes:
- Adds a no-op InvokeBuild task (
NoOp) so the pipeline’s post-compile phase can always execute. - Configures the workflow to run that no-op task via
postCompilePhaseTasks, keeping the publish phase unblocked on tagged builds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.zf/config.ps1 |
Adds an empty NoOp InvokeBuild task used to keep the post-compile phase alive. |
.github/workflows/build.yml |
Sets postCompilePhaseTasks: 'NoOp' so the reusable pipeline includes the post-compile job and doesn’t skip publish. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HowardvanRooijen
added
the
pending_release
endjin-bot
Bot
removed
the
pending_release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors ais-dotnet/Ais.Net.Models#9. The endjin pipeline's publish phase has
needs: postCompile, and the post-compile phase only runs whenpostCompilePhaseTasksis set (if: inputs.postCompilePhaseTasks != ''). With it unset, post-compile is skipped, which cascades to skip publish on tagged builds (publish'sifdoesn't usealways()). This is whyAis.Net.Models.Jsondid not publish.Points
postCompilePhaseTasksat a no-op InvokeBuild task (NoOp, added to.zf/config.ps1) so the post-compile phase runs and no longer blocks publish. On this PR's build, the Post-Compile job should now run (previously skipped).🤖 Generated with Claude Code