Conversation
Assisted-by: GPT-5.6 Sol Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-5.6 Sol Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-5.6 Sol Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-5.6 Sol Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-5.6 Sol Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 12, 2026
Assisted-by: GPT-5.6 Sol Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-5.6 Sol Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-5.6 Sol Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-5.6 Sol Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Stacked on #3 at independently approved attention commit
c51c971392ca4ee0fe502c532bbe415b14f8a71a, which incorporates corrected schema head65fdc19831d30b12f06b981c3ca74dd18731f90e.[264, rows]table extents without allocating, mapping, warming, or reading the complete tensors[token][2][24], read both bounded row packs before execution, and upload each layer pack through backend input tensorsDesign and tracking: halo-box#48. Schema dependency: halo-box#49. Attention dependency: #3.
Reference oracle: antirez/ds4
bd66c402070042bf0a79ad6ece8242de4c93680c.Measurements
No performance claim is made. The complete model remains intentionally gated on the missing routed-expert store/execution layer, so no valid Strix Halo benchmark can be run for this PR in isolation.
Correctness:
test-engramtest-deepseek41-engramtest-deepseek41-runtimetest-deepseek41-schematest-llama-archs -a qwen4exppython3 -m pytest -q gguf-py/tests/test_deepseek41_schema.pytest-llama-archs -a deepseek41git diff --checkThe focused tests cover exact IDs, masked rows including non-BF16 values and signed zero, layer selection and 48-ID token stride, chunked-prefill history, transactional failures, multi-sequence operations, scheduler-backed bounded uploads, projection, gate math, positive/negative-zero copysign behavior, and mixed-backend assignment that keeps surrounding matrix work accelerated while the callback executes on local CPU.
Additional information
The 365 GB published GGUF was not opened. Synthetic sparse test data exercises bounded uncached row reads only. Normal model loading records each Engram table's file, absolute offset, type, and shape, then registers it with
TENSOR_SKIP; the model exits on the routed-expert dependency before normal payload mapping begins.The signed-square-root gate uses a small scheduler-pinned local CPU custom operation until GGML provides a backend-wide copysign primitive. The builder rejects non-CPU backends and CPU backends that are not registered in the scheduler. This prevents RPC from receiving a process-local callback pointer while preserving the oracle's
copysignbehavior for positive and negative zero. Masked positions select the original residual row withget_rows, so they bypass BF16 rounding byte-for-byte.The final Engram core input is #2 head
68df4a97268c457a8b9a1e199864a79d8df03097(treed29fe52949867680c39bc15e7bcc6e9fa7cb33bb). Its six implementation/test files are byte-identical in this PR; the only expected delta is the DeepSeek V4.1 runtime and test registration in the two CMake files.The source commits in this stack are:
74c5167c7f8107404364c9161158652a1eadb1d6- bounded disk table, hashing, and decode core8a59f344389368b591a11fa717bca3a7cdf329bf- bounded read failure handling4a214505044d8e0a8d136a8f1737bab727be6814- DeepSeek V4.1 runtime, model wiring, graph, and tests78175bfc2- exact masked-row and signed-zero gate semantics4ac4d4a84- local CPU scheduler pin and mixed-backend regressione094c50c5- normal merge of the repaired attention/schema based57dd1c5a- normal merge of the updated attention/schema base0ed3b2eb9- single reconciliation with the final corrected attention/schema input0fa6b96b2- reconciliation with the independently approved attention fixesRequirements