Skip to content

fix(terminal): gate per-frame repaint on dirty flag #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vadim1987 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(terminal): gate per-frame repaint on dirty flag #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/model/canvasModel.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ end
function CanvasModel:write(text)
if string.is_non_empty_string(text) then
self.terminal:print(text)
self.terminal.dirty = true
end
end

Expand All @@ -70,9 +71,11 @@ end
function CanvasModel:reset()
self.terminal:clear()
self.terminal:move_to(1, 1)
self.terminal.dirty = true
end

function CanvasModel:invalidate_terminal()
self.terminal.dirty = true
end

function CanvasModel:update(dt)
Expand Down
4 changes: 2 additions & 2 deletions src/view/canvas/terminalView.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ local function terminal_draw(terminal, canvas, overlay)
local char_width, char_height =
terminal.char_width, terminal.char_height

-- if terminal.dirty or overlay then
if terminal.dirty or overlay then
Comment thread
dsent marked this conversation as resolved.
gfx.push('all')

gfx.setCanvas(canvas)
Expand Down Expand Up @@ -61,7 +61,7 @@ local function terminal_draw(terminal, canvas, overlay)
end
terminal.dirty = false
gfx.pop()
-- end
end
Comment thread
dsent marked this conversation as resolved.


if terminal.show_cursor then
Expand Down
Loading