Skip to content

fix: guard menus while dialogs are active#239

Open
PathGao wants to merge 1 commit into
alecdotdev:masterfrom
PathGao:codex/fix-menu-modal-guards
Open

fix: guard menus while dialogs are active#239
PathGao wants to merge 1 commit into
alecdotdev:masterfrom
PathGao:codex/fix-menu-modal-guards

Conversation

@PathGao

@PathGao PathGao commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #215.

Fixes #216.

Summary

  • Close titlebar menus before a right-click opens a document or tab context menu, and when the window loses focus.
  • Block document context-menu creation while an in-app modal is active.
  • Consume context-menu events on the modal backdrop.

Validation

  • node --test --import tsx scripts/menuModalGuards.test.ts
  • npm run check

@PathGao
PathGao marked this pull request as ready for review July 24, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant