Implementation of monomial divisibility diagrams for efficient membership tests#129
Conversation
f9be7f7 to
73e4f1b
Compare
|
@ThTer11 I did some small changes, for me the main code looks good now. So if you think it's good as well, you can remove the Draft status. The one bigger thing I did was to integrate the Hilbert series computation via MDD's into the already present functionality for computing Hilbert series. In the user function |
|
Many thanks for this. It looks like the tests are not successful. Can you have a look? |
Fixed! |
…d add automatic tests
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
- Coverage 83.62% 82.70% -0.93%
==========================================
Files 32 33 +1
Lines 3188 3544 +356
==========================================
+ Hits 2666 2931 +265
- Misses 522 613 +91 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This draft pull request implements monomial divisibility diagrams (MDDs) in AlgebraicSolving.jl, following the ideas from our paper A data structure for monomial ideals with applications to signature Gröbner bases (Pierre Lairez, Rafael Mohr, Théo Ternier, link: https://arxiv.org/abs/2601.05026).
The goal is to speed up membership tests in monomial ideals, which are used in the signature Gröbner basis implementation.