Skip to content

Fix for random multipliers in F4 linear algebra #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ederc wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for random multipliers in F4 linear algebra #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e77f709
fixes randomized multipliers for 8
ederc Jun 26, 2026
317f15c
fixes randomized multipliers for 16
ederc Jun 26, 2026
dc63955
fixes randomized multipliers for 32
ederc Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/neogb/la_ff_16.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,9 @@ static void probabilistic_sparse_reduced_echelon_form_ff_16(

/* fill random value array */
for (j = 0; j < nrbl; ++j) {
mull[j] = (int64_t)rand() % fc;
do {
mull[j] = (int64_t)rand() & fc;
} while (mull[j] == 0);
}
/* generate one dense row as random linear combination
* of the rows of the block */
Expand Down Expand Up @@ -1675,7 +1677,9 @@ static cf16_t **probabilistic_dense_linear_algebra_ff_16(

/* fill random value array */
for (j = 0; j < nrbl; ++j) {
mull[j] = (int64_t)rand() % fc;
do {
mull[j] = (int64_t)rand() & fc;
} while (mull[j] == 0);
}
/* generate one dense row as random linear combination
* of the rows of the block */
Expand Down Expand Up @@ -1807,7 +1811,9 @@ static cf16_t **probabilistic_sparse_dense_echelon_form_ff_16(

/* fill random value array */
for (j = 0; j < nrbl; ++j) {
mull[j] = (int64_t)rand() % fc;
do {
mull[j] = (int64_t)rand() & fc;
} while (mull[j] == 0);
}
/* generate one dense row as random linear combination
* of the rows of the block */
Expand Down
16 changes: 12 additions & 4 deletions src/neogb/la_ff_32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,9 @@ static int is_kernel_trivial(

/* fill random value array */
for (i = 0; i < ncr; ++i) {
mul[i] = (int64_t)rand() & fc;
do {
mull[j] = (int64_t)rand() & fc;
} while (mull[j] == 0);
}
for (i = 0; i < sat->ld; ++i) {
memset(dr, 0, (uint64_t)dim * sizeof(int64_t));
Expand Down Expand Up @@ -2382,7 +2384,9 @@ static void probabilistic_sparse_reduced_echelon_form_ff_32(

/* fill random value array */
for (j = 0; j < nrbl; ++j) {
mull[j] = (int64_t)rand() & mask;
do {
mull[j] = (int64_t)rand() & mask;
} while (mull[j] == 0);
}
/* generate one dense row as random linear combination
* of the rows of the block */
Expand Down Expand Up @@ -3599,7 +3603,9 @@ static cf32_t **probabilistic_dense_linear_algebra_ff_32(

/* fill random value array */
for (j = 0; j < nrbl; ++j) {
mull[j] = (int64_t)rand() & mask;
do {
mull[j] = (int64_t)rand() & mask;
} while (mull[j] == 0);
}
/* generate one dense row as random linear combination
* of the rows of the block */
Expand Down Expand Up @@ -3731,7 +3737,9 @@ static cf32_t **probabilistic_sparse_dense_echelon_form_ff_32(

/* fill random value array */
for (j = 0; j < nrbl; ++j) {
mull[j] = (int64_t)rand() % fc;
do {
mull[j] = (int64_t)rand() & fc;
} while (mull[j] == 0);
}
/* generate one dense row as random linear combination
* of the rows of the block */
Expand Down
12 changes: 9 additions & 3 deletions src/neogb/la_ff_8.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,7 +927,9 @@ static void probabilistic_sparse_reduced_echelon_form_ff_8(

/* fill random value array */
for (j = 0; j < nrbl; ++j) {
mull[j] = (int64_t)rand() % fc;
do {
mull[j] = (int64_t)rand() & fc;
} while (mull[j] == 0);
}
/* generate one dense row as random linear combination
* of the rows of the block */
Expand Down Expand Up @@ -1804,7 +1806,9 @@ static cf8_t **probabilistic_dense_linear_algebra_ff_8(

/* fill random value array */
for (j = 0; j < nrbl; ++j) {
mull[j] = (int64_t)rand() % fc;
do {
mull[j] = (int64_t)rand() & fc;
} while (mull[j] == 0);
}
/* generate one dense row as random linear combination
* of the rows of the block */
Expand Down Expand Up @@ -1936,7 +1940,9 @@ static cf8_t **probabilistic_sparse_dense_echelon_form_ff_8(

/* fill random value array */
for (j = 0; j < nrbl; ++j) {
mull[j] = (int64_t)rand() % fc;
do {
mull[j] = (int64_t)rand() & fc;
} while (mull[j] == 0);
}
/* generate one dense row as random linear combination
* of the rows of the block */
Expand Down
Loading