fix(tokenless): add missing _common.sh to RPM spec - #2425
Conversation
68d7e95 to
97c0151
Compare
ikunkun-sys
left a comment
There was a problem hiding this comment.
The packaging change itself looks correct. I independently built the Tokenless RPM on Alibaba Cloud Linux 3 x86_64 and verified that _common.sh is included as root:root 0644, while install.sh and uninstall.sh remain executable. The extracted helper can also be sourced successfully.
One non-blocking process issue remains:
[P2] The standalone fix commit does not include the required Fixes: attribution. Both _common.sh and the corresponding source statements were introduced by 9ca77820, which is already on main. Per AGENTS.md §13, the commit body should identify that originating commit before merge.
97c0151 to
7313b4c
Compare
|
@ikunkun-sys 感谢 review!已按意见处理 [P2] 缺
麻烦再帮忙看一眼,谢谢! |
7313b4c to
4338c9e
Compare
ikunkun-sys
left a comment
There was a problem hiding this comment.
The code and RPM packaging change remain correct, and the previous missing-Fixes: finding has been addressed. The new and previously reviewed commits have identical trees.
One non-blocking commit-message issue remains:
[P2] The wrapped Fixes: trailer now contains a literal backslash. On 4338c9ee, git interpret-trailers --parse produces schema, \\ permissions, so the quoted subject no longer matches the actual subject of 9ca77820. Please wrap the trailer using a normal continuation line without a shell-style backslash. Commit Message Lint passes on this revision, but the attribution text itself is inaccurate.
ikunkun-sys
left a comment
There was a problem hiding this comment.
Requesting changes for the outstanding commit-attribution issue noted in the latest review.
The wrapped Fixes: trailer contains a literal backslash, so its quoted subject does not match the actual subject of 9ca77820. Please use a normal continuation line without a shell-style backslash. The code and RPM packaging change itself remains verified and otherwise looks correct.
4338c9e to
865d4b6
Compare
|
@ikunkun-sys Thanks for catching the backslash issue in the New head: |
The _common.sh helper is sourced by install.sh but was never copied into the RPM buildroot or listed in %files. Add it with 0644 permissions alongside the other Codex lifecycle scripts. Fixes: 9ca7782 ("fix(tokenless): harden env-fix, version extraction, file trust, schema, \ permissions") Assisted-by: Qoder:1.0.45 Signed-off-by: linyan.lin <linyan.lin@alibaba-inc.com> Co-authored-by: multica-agent <github@multica.ai>
865d4b6 to
184f74c
Compare
ikunkun-sys
left a comment
There was a problem hiding this comment.
Requesting changes on the latest revision because the commit attribution is still malformed.
On 184f74c5, the Fixes: trailer again contains a literal backslash. git interpret-trailers --parse returns schema, \\ permissions, which does not match the actual subject of 9ca77820. The single-line form fixes the trailer value but fails the 100-character commit-message limit.
Please use Git's normal indented trailer continuation, without a backslash:
Fixes: 9ca77820 ("fix(tokenless): harden env-fix, version extraction, file trust,
schema, permissions")
This form was locally verified to parse back to the exact original subject, and both physical lines are under 100 characters. The code tree remains identical to the previously verified RPM packaging change.
Summary
_common.shis sourced by the Codexinstall.shscript but was never installed into the RPM buildroot or listed in%files. This causesinstall.shto fail at runtime with "No such file or directory" after installing the tokenless RPM.Add the helper to both the
%installsection (with0644permissions) and the%filessection so it is packaged alongside the other Codex lifecycle scripts.Closes #2420.
Risk and compatibility
0644) match the file's read-only helper nature.Validation
src/tokenless/adapters/tokenless/codex/scripts/_common.shexists in the source tree.bash scripts/rpm-build.sh tokenlesssucceeds locally and produces an RPM containing_common.sh.