Skip to content

docs: fill in missing translations of ocr session comments - #774

Closed
wu21-web wants to merge 1 commit into
alibaba:mainfrom
wu21-web:docs
Closed

docs: fill in missing translations of ocr session comments#774
wu21-web wants to merge 1 commit into
alibaba:mainfrom
wu21-web:docs

Conversation

@wu21-web

@wu21-web wu21-web commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Description

Fill in missing translations of

# Print the review comments recorded in a saved session
ocr session comments <session-id>
ocr session comments --severity critical,high --json <session-id>

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring (no functional changes)
  • Documentation update
  • CI / Build / Tooling

How Has This Been Tested?

  • make test passes locally
  • Manual testing (describe below)

Checklist

  • My code follows the project's coding style (go fmt, go vet)
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly (if applicable)
  • I have signed the CLA

Related Issues

none yet

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

OpenCodeReview: Review skipped: no items were selected.

@lizhengfeng101

Copy link
Copy Markdown
Collaborator

@wu21-web The readme file should not be too bloated. Please keep only the main information and move other information to the documentation site.

@wu21-web

wu21-web commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@lizhengfeng101 I think maybe there is a misunderstanding. Translations are missing, and i'm keeping them in sync.

image

Other READMEs:
Screenshot 2026-08-07 at 11 13 08 PM

Let me know what you think.

@lizhengfeng101

Copy link
Copy Markdown
Collaborator

@wu21-web Sorry, I wasn't clear enough in my previous comment. What I'm suggesting is that we migrate this section of content to the documentation site — including the existing localized READMEs. This isn't about your specific changes; it's a broader direction we'd like to take to keep the README lean. We can track that migration separately. Thanks for keeping the translations in sync!

@wu21-web
wu21-web marked this pull request as draft August 7, 2026 14:23
@wu21-web

wu21-web commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

This is introduced in PR #646 , and it already updated in the docs of doc site, closing.

@wu21-web wu21-web closed this Aug 7, 2026
@wu21-web wu21-web changed the title docs: fill in missing translations of ocr * docs: fill in missing translations of ocr session comments Aug 7, 2026
@lizhengfeng101

Copy link
Copy Markdown
Collaborator

@wu21-web I checked PR #646 — it introduced this content in the README, and I noticed the doc site is still missing one language version. Would you be willing to reopen this PR to remove the relevant section from the README and add the missing language to the doc site instead? That way we keep the README lean and the doc site complete. Totally up to you — happy to help if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants