fix(review): filter near-duplicate comments in review output - #776
Open
amh1k wants to merge 1 commit into
Open
Conversation
Contributor
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes near-duplicate review comments in JSON and GitLab output.
The existing review filter only received comment text and existing code, so it could not reliably identify comments targeting the same file and location. The filter payload now includes file paths, resolved line ranges, suggested code, categories, and severities.
The review-filter prompt now removes only high-confidence duplicates while preserving complementary or uncertain findings. Filtering remains fail-open if the LLM response is invalid or unavailable.
Type of Change
How Has This Been Tested?
go vet ./...gofmt -s -l .git diff --checkgo mod tidywith no module changesTests cover duplicate removal, line-number resolution, metadata preservation, cross-file isolation, malformed responses, and fail-open behavior.
Checklist
go fmt,go vet)Related Issues
Closes #709