Skip to content

Use WebView from react-native-webview as it has been deprecated from …#289

Open
cj3g10 wants to merge 1 commit into
alinz:masterfrom
cj3g10:master
Open

Use WebView from react-native-webview as it has been deprecated from …#289
cj3g10 wants to merge 1 commit into
alinz:masterfrom
cj3g10:master

Conversation

@cj3g10

@cj3g10 cj3g10 commented Feb 26, 2019

Copy link
Copy Markdown

Use WebView from react-native-webview as it has been deprecated from react-native and will be removed in future release.

See https://facebook.github.io/react-native/docs/webview for more info.

@fungilation fungilation left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this before WebView deprecation in RN 0.59+

Hard for me to review changes in index.ios.js by just looking at diff, due to a lot of code re-ordering. I'll test later and comment. I assume you have tested this PR in your own app?

@cj3g10

cj3g10 commented Feb 26, 2019

Copy link
Copy Markdown
Author

Yes, I'm currently using this PR in my own app.
I thought I turned off my formatting add-on, so I didn't realize index.ios.js had a lot of code re-ordering.

@cj3g10

cj3g10 commented Feb 27, 2019

Copy link
Copy Markdown
Author

One more thing: I think we will also need to add react-native link react-native-webview to the install instructions.

@fungilation

Copy link
Copy Markdown
Contributor

One more thing: I think we will also need to add react-native link react-native-webview to the install instructions.

Yup. @chansuke merge please?

@fungilation

fungilation commented Apr 19, 2019

Copy link
Copy Markdown
Contributor

@chansuke? Is no one maintaining this again?

I confirm this PR works perfectly in my app WonderSwipe, and is needed for RN 0.59.5. Please merge.

@vendicto

Copy link
Copy Markdown

@fungilation Could you merge it?

@fungilation

Copy link
Copy Markdown
Contributor

Nope. No write access.

@rosmcmahon

Copy link
Copy Markdown

this still needs to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants