Skip to content

Add P/D network dimension to Vidur config explorer - #302

Draft
tianhao909 with Copilot wants to merge 2 commits into
masterfrom
copilot/add-pd-networks-dimension
Draft

Add P/D network dimension to Vidur config explorer#302
tianhao909 with Copilot wants to merge 2 commits into
masterfrom
copilot/add-pd-networks-dimension

Conversation

Copilot AI commented Aug 27, 2026

Copy link
Copy Markdown

Vidur’s config explorer could not sweep P/D deployment ratios and network parameters, preventing direct capacity and Pareto comparisons across P/D network configurations.

  • Design-space generation

    • Add optional pd_networks dimension.
    • Map ratio, P/D bandwidth, RDMA bandwidth, NVLink bandwidth, and transfer dtype to existing ReplicaConfig arguments.
  • Validation

    • Reject invalid ratios, non-positive bandwidths, unsupported dtypes, missing names, and duplicate points.
    • Skip TP/PP combinations that produce zero P or D replicas before simulation.
  • Job identity

    • Include every explicit network parameter in deterministic job/cache keys.
    • Preserve the existing mixed-serving job and key when pd_networks is omitted.
  • Configuration example

pd_networks:
  - name: pd-balanced-100g
    pd_node_ratio: 0.5
    pd_p2p_comm_bandwidth: 100
    rdma_bandwidth: 100
    nvlink_bandwidth: 900
    pd_p2p_comm_dtype: float16

Capacity search and Pareto analysis continue consuming generated runs without changes.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Co-authored-by: tianhao909 <48342395+tianhao909@users.noreply.github.com>
Copilot AI changed the title [WIP] Add optional pd_networks dimension to config optimizer Add P/D network dimension to Vidur config explorer Aug 27, 2026
Copilot AI requested a review from tianhao909 August 27, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Sweep P/D deployment and network dimensions in Vidur config optimizer

3 participants