Fix CSV user import with UTF-8 BOM and improve error handling - #849
Open
rgaviras wants to merge 4 commits into
Open
Fix CSV user import with UTF-8 BOM and improve error handling#849rgaviras wants to merge 4 commits into
rgaviras wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes CSV user imports for UTF-8 files with BOM when the first header is not quoted.
The issue occurs with valid CSV files like:
name;firstname;lastname;email;passwordWhen the file starts with a UTF-8 BOM, the importer reads the first column as
\ufeffnameinstead ofname. It then tries to resolve a dynamic setter for that field, fails to find theexpected
CmsUser#setName(String), and the import can fail with unclear behavior.This PR:
CmsUser#setXxx(String)reflection behavior;namecolumn and empty user names with clear errors;IndexOutOfBoundsException;name, and password fallback behavior.Validated with:
./gradlew compileJava./gradlew testSingle --tests org.opencms.ui.apps.user.TestCmsCsvImportUtilsAlso manually tested on OpenCms 21.0.1 by replacing
opencms.jarin a container.