Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions config/settings/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,11 @@
True,
)

NOTIFY_BOOKS = DynamicSetting(
"core.GrumpySettings.notify_books",
False,
)

PASSWORD_MIN_LENGTH = DynamicSetting(
"core.GrumpySettings.password_min_length",
8,
Expand Down
32 changes: 32 additions & 0 deletions grumpy/books/views.py
Original file line number Diff line number Diff line change
@@ -1,18 +1,31 @@
import copy
import logging

from django.conf import settings
from django.contrib import messages
from django.contrib.auth.mixins import LoginRequiredMixin, UserPassesTestMixin
from django.contrib.sites.shortcuts import get_current_site
from django.core.mail import mail_managers
from django.views.generic.edit import CreateView, DeleteView, UpdateView
from django.views.generic.list import ListView
from django.urls import reverse_lazy

from allauth.account.adapter import get_adapter

from grumpy.core.utils import is_error
from grumpy.books.forms import BookForm
from grumpy.books.models import Book

logger = logging.getLogger(__name__)


def notify(request, subject, message):
adapter = get_adapter(request)
subject = adapter.format_email_subject(subject)
message = f"{message} [{get_current_site(request)}]"
mail_managers(subject, message, fail_silently=True)


class BookListView(LoginRequiredMixin, ListView):
model = Book
fields = [
Expand Down Expand Up @@ -49,6 +62,14 @@ def form_valid(self, form):
messages.add_message(
self.request, messages.SUCCESS, f'Successfully added "{self.object}".'
)

if settings.NOTIFY_BOOKS:
notify(
self.request,
"new book created",
f"User {current_user} created a new book: {self.object.id}.",
)

return response

def test_func(self):
Expand Down Expand Up @@ -104,9 +125,20 @@ def test_func(self):
return user_can_delete_book

def form_valid(self, form):
deleted_book = copy.copy(
self.object
) # shallow copy to refer to book details after it's been deleted
response = super().form_valid(form)
if not is_error(response.status_code):
messages.add_message(
self.request, messages.SUCCESS, f'Successfully deleted "{self.object}".'
)

if settings.NOTIFY_BOOKS:
notify(
self.request,
"book deleted",
f"User {self.request.user} deleted a book: {deleted_book.id}.",
)

return response
1 change: 1 addition & 0 deletions grumpy/core/admin/admin_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class GrumpySettingsAdmin(admin.ModelAdmin):
"allow_signup",
"require_approval",
"notify_signups",
"notify_books",
"password_min_length",
"password_max_length",
"password_strength",
Expand Down
21 changes: 21 additions & 0 deletions grumpy/core/migrations/0005_grumpysettings_notify_books.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Generated by Django 5.2.7 on 2026-08-14 09:10

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
("core", "0004_grumpysettings_notify_signups"),
]

operations = [
migrations.AddField(
model_name="grumpysettings",
name="notify_books",
field=models.BooleanField(
default=False,
help_text="Notify managers when a book is added or deleted.",
),
),
]
5 changes: 5 additions & 0 deletions grumpy/core/models/models_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ class Meta:
help_text=_("Notify managers when a new user signs up."),
)

notify_books = models.BooleanField(
default=False,
help_text=_("Notify managers when a book is added or deleted."),
)

password_min_length = models.PositiveIntegerField(
default=6, help_text=_("Minimum length of a user password")
)
Expand Down
Loading