fix: PlayerItemUseEvent firing twice on right-click - #32
Merged
xRookieFight merged 3 commits intoAug 13, 2026
Conversation
Contributor
|
I couldn't reproduce the bug before, can you send some footage for it? |
Contributor
Author
Contributor
|
I assume it's only happening on fishing rod, right? It's not reproducable on other items. |
Contributor
Author
|
I try more with some items like
So it looks like it's specific to items that have a "charge up" / hold-to-use |
Contributor
|
Hmm, okay. I'll review the code. I assume this is new on 1.26.40 so it also may be a protocol issue too |
xRookieFight
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #28
Changes
Found the bug - handleRightClickItemUse() gets called twice for one
right-click. This happens because START_USING_ITEM flag triggers it once,
and then itemInteractionData (ACTION_CLICK_AIR) triggers it again, both
from the same PlayerAuthInputPacket. Added a check so it only fires once
now.
Tests
Tested with a test plugin that spawns something on PlayerItemUseEvent.
Before the fix it spawned twice per click, now it only spawns once.