Skip to content

[FIX] sentry: start on sentry-sdk newer than 1.9.0 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yibudak merged 1 commit into from
Sep 14, 2026
Merged

[FIX] sentry: start on sentry-sdk newer than 1.9.0 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sentry/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{
"name": "Sentry",
"summary": "Report Odoo errors to Sentry",
"version": "16.0.3.0.3",
"version": "16.0.3.0.4",
"category": "Extra Tools",
"website": "https://github.com/OCA/server-tools",
"author": "Mohammed Barsi,"
Expand All @@ -17,7 +17,7 @@
"installable": True,
"external_dependencies": {
"python": [
"sentry_sdk<=1.9.0",
"sentry_sdk<2",
]
},
"depends": [
Expand Down
14 changes: 12 additions & 2 deletions sentry/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,22 @@ def get_sentry_logging(level=DEFAULT_LOG_LEVEL):
)


def renamed_option(new_key, old_key, converter=None):
"""An option sentry-sdk renamed after 1.9.0, under the installed SDK's name.

``sentry_sdk.init`` rejects the other name, and reading the missing key from
``DEFAULT_OPTIONS`` raised KeyError at server start once the SDK was upgraded.
"""
key = new_key if new_key in DEFAULT_OPTIONS else old_key
return SentryOption(key, DEFAULT_OPTIONS[key], converter)


def get_sentry_options():
res = [
SentryOption("dsn", "", str.strip),
SentryOption("transport", DEFAULT_OPTIONS["transport"], select_transport),
SentryOption("logging_level", DEFAULT_LOG_LEVEL, get_sentry_logging),
SentryOption("with_locals", DEFAULT_OPTIONS["with_locals"], None),
renamed_option("include_local_variables", "with_locals"),
SentryOption(
"max_breadcrumbs", DEFAULT_OPTIONS["max_breadcrumbs"], to_int_if_defined
),
Expand All @@ -107,7 +117,7 @@ def get_sentry_options():
SentryOption("http_proxy", DEFAULT_OPTIONS["http_proxy"], None),
SentryOption("https_proxy", DEFAULT_OPTIONS["https_proxy"], None),
SentryOption("ignore_exceptions", DEFAULT_IGNORED_EXCEPTIONS, split_multiple),
SentryOption("request_bodies", DEFAULT_OPTIONS["request_bodies"], None),
renamed_option("max_request_body_size", "request_bodies"),
SentryOption("attach_stacktrace", DEFAULT_OPTIONS["attach_stacktrace"], None),
SentryOption("ca_certs", DEFAULT_OPTIONS["ca_certs"], None),
SentryOption("propagate_traces", DEFAULT_OPTIONS["propagate_traces"], None),
Expand Down