feat: Allow OpenQASM strings in CircuitBinding#1274
Open
speller26 wants to merge 9 commits into
Open
Conversation
This will allow users to run program sets with programs using advanced OpenQASM features like dynamic circuits.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 171 171
Lines 11401 11481 +80
Branches 1480 1498 +18
=========================================
+ Hits 11401 11481 +80 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sesmart
reviewed
Jun 22, 2026
|
|
||
|
|
||
| @dataclass | ||
| class _ParsedOpenQASM: |
Contributor
There was a problem hiding this comment.
Should we have an OQ3 container class? Or should these just be functional?
Contributor
There was a problem hiding this comment.
Should this live in the circuit_binding class, and how much is more general than this?
| ).as_dict(), | ||
| ) | ||
|
|
||
| def _circuit_source( |
| measure_index = stmt.span.start_line - 1 | ||
|
|
||
| qubit_format, qubits = ( | ||
| (f"{register_name}[{{}}]", QubitSet(range(register_size))) |
| if isinstance(stmt, QubitDeclaration) and register_name is None: | ||
| register_name = stmt.qubit.name | ||
| # stmt.size is None for a single unindexed qubit | ||
| register_size = stmt.size.value if isinstance(stmt.size, IntegerLiteral) else 1 |
Contributor
There was a problem hiding this comment.
Can this handle more than one register?
| circuit_qubits = self._circuit_qubits() | ||
| if isinstance(observables, Sum): | ||
| if observables.targets: | ||
| return QubitSet(t for obs in observables.summands for t in obs.targets) |
Contributor
There was a problem hiding this comment.
Can't you union over observables.targets?
| @@ -17,7 +17,7 @@ extras = test | |||
| deps = | |||
| {[test-deps]deps} | |||
| commands = | |||
| assert parsed.qubits == QubitSet([0]) | ||
|
|
||
|
|
||
| def test_string_circuit_broadcast_gate(): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow users to run program sets with programs using advanced OpenQASM features like dynamic circuits.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.