Sync SDK with Etsy API spec — batch inventory & shipping endpoints#33
Merged
Conversation
Sync SDK with latest Etsy OAS spec. Two GET batch endpoints were missing from the SDK: - getListingsInventoryByListingIds -> get_listings_inventory_by_listing_ids (GET /v3/application/listings/batch/inventory) - getListingsShippingByListingIds -> get_listings_shipping_by_listing_ids (GET /v3/application/listings/batch/shipping) Both take a single required listing_ids query param (comma-joined), following the existing get_listings_by_listing_ids batch pattern. Adds resource methods plus unit tests, bringing OAS coverage to 100%. The rich_description property added to ShopListing/ShopListingWithAssociations is response-only and needs no SDK change. Baseline refreshed to the latest spec; all 11 audit suppressions re-verified as still valid. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
amitray007
added
the
api-drift
Contributor
Test Coverage ReportOverall: 100% (1680/1680 statements covered) Coverage by file
Updated by PR Tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SDK coverage audit against the latest Etsy OAS spec surfaced two GET batch endpoints missing from the SDK. This PR adds them, bringing OAS coverage from 98.1% → 100%.
Should Fix — 2 items (implemented):
getListingsInventoryByListingIds→get_listings_inventory_by_listing_idsGET /v3/application/listings/batch/inventorygetListingsShippingByListingIds→get_listings_shipping_by_listing_idsGET /v3/application/listings/batch/shippingBoth take a single required
listing_idsquery param (array of int64), comma-joined, following the existingget_listings_by_listing_idsbatch pattern.Informational (no code change):
rich_descriptionadded toShopListing/ShopListingWithAssociations— response-only field; the SDK does not model response schemas, so no change needed.createDraftListing/updateListingare pre-existing; Etsy has not removed the fields.Audit suppressions: all 11 re-verified as still valid (4 deprecated aliases + holiday_id/State/Includes enum decisions); 0 stale ignores; no newly-surfaced enum values.
specs/audit-ignore.jsonunchanged.The spec baseline (
specs/baseline.json) was refreshed to the latest spec.Test plan
pytest -v— 344 passedlisting_idsfor each method (TestGetListingsInventoryByListingIds,TestGetListingsShippingByListingIds)python scripts/audit_sdk.py --spec specs/latest.json— 0 missing, 100% coverage🤖 Generated with Claude Code