Skip to content

Fork ResizeObserver polyfill to support shadow DOM and FIE - #31850

Merged
dvoytenko merged 2 commits into
ampproject:masterfrom
dvoytenko:run3/resize-obs-sd
Jan 8, 2021
Merged

Fork ResizeObserver polyfill to support shadow DOM and FIE#31850
dvoytenko merged 2 commits into
ampproject:masterfrom
dvoytenko:run3/resize-obs-sd

Conversation

@dvoytenko

Copy link
Copy Markdown
Contributor

Partial for #31540.

See que-etc/resize-observer-polyfill#79 for more details.

@dvoytenko
dvoytenko requested a review from samouri January 7, 2021 23:33
@samouri

samouri commented Jan 8, 2021

Copy link
Copy Markdown
Member

nit: rename from upgrade to fork ?

Comment thread build-system/tasks/update-packages.js
@dvoytenko dvoytenko changed the title Upgrade ResizeObserver polyfill to support shadow DOM and FIE Fork ResizeObserver polyfill to support shadow DOM and FIE Jan 8, 2021
@dvoytenko

Copy link
Copy Markdown
Contributor Author

nit: rename from upgrade to fork ?

done

@samouri samouri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we'd potentially be better served by promoting this to its own repo? E.g. ampproject/resize-observer-polyfill

@dvoytenko

Copy link
Copy Markdown
Contributor Author

Do you think we'd potentially be better served by promoting this to its own repo? E.g. ampproject/resize-observer-polyfill

We will do it if we do not get the response. But I think the rule of thumb for now is to give a few weeks before forking.

@dvoytenko
dvoytenko merged commit 4209fe9 into ampproject:master Jan 8, 2021
@dvoytenko
dvoytenko deleted the run3/resize-obs-sd branch January 8, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants