fix config unavailability for a device without data_source - #207
Closed
SAY-5 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Owner
|
Hey @SAY-5,
If you still wish to contribute to this project, I'd suggest to focus on another open issue. You can leave a comment and ask to assign an issue to you before beginning your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #206
_config_itemalready handleddata_sourcebeingNone, but not the attribute being missing entirely, which is what happens when a device is fetched directly (e.g.VDevice.objects.get(...)in the shell) withoutprefetch_datasource()/set_datasource(). The missing-attributeAttributeErrorhasobjset to the device, so the existing guard re-raised it. Treat that case the same asdata_source is None.