chore(ui): remove unused button and input exports#228
Open
andrerfneves wants to merge 1 commit into
Open
Conversation
Remove buttonVariants and ButtonProps from the button.tsx export list, and remove the InputProps interface from input.tsx (using inline React.InputHTMLAttributes instead). These exports are never imported by any other file in the project. The internal variables/interfaces remain in the file since they are used by the component implementations. Consistent with similar cleanup PRs: - #213, #207, #203 (dialog) - #201 (dropdown-menu) - #200 (sheet)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes unused exports from two shadcn/ui components:
button.tsxandinput.tsx.Why
button.tsx
buttonVariantsandButtonPropsare used internally by theButtoncomponent but are never imported by any other file in the project. Removing them from the export list keeps the public API surface minimal.input.tsx
InputPropsserved as a pass-through interface (extends React.InputHTMLAttributes<HTMLInputElement> {}) that added no additional properties. It was never imported externally. Replaced with inlineReact.InputHTMLAttributes<HTMLInputElement>directly in the component's type signature.This is consistent with the established cleanup pattern in the repository:
badgeVariantsexport frombadge.tsxdialog.tsxdropdown-menu.tsxsheet.tsxChanges
src/components/ui/button.tsx: Changedexport { Button, buttonVariants }→export { Button }src/components/ui/input.tsx: Removed theInputPropsinterface and used inlineReact.InputHTMLAttributes<HTMLInputElement>insteadTest Plan