[settings] add work hours support#244
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR adds work-hours fields to message settings maps and the OpenAPI schema, and bumps the ChangesWork Hours Settings
Client-go Dependency Update
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/sms-gateway/openapi/docs.go`:
- Around line 2208-2219: The work_hours_end and work_hours_start fields in the
OpenAPI schema are defined as simple string types without any format validation,
which means generated clients and validators cannot enforce the HH:mm format
constraint mentioned in the descriptions. Add a pattern property to both the
work_hours_end and work_hours_start field definitions with a regex pattern that
validates the HH:mm format (24-hour), such as a pattern that matches two digits
for hours (00-23), a colon, and two digits for minutes (00-59). This will ensure
that API clients and validators can properly validate the time format at the
schema level.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a6e33db2-2172-407e-aa35-21b33ceed3e1
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
go.modinternal/sms-gateway/modules/settings/utils.gointernal/sms-gateway/openapi/docs.go
🤖 Pull request artifacts
|
a05068c to
c5a9953
Compare
c5a9953 to
d357a64
Compare
d357a64 to
0b4dd74
Compare
0b4dd74 to
913f67d
Compare
913f67d to
e9065ee
Compare
Summary by CodeRabbit
app:startedwebhook event for application startup notifications.app:startedwebhook event definition.