refactor(@schematics/angular): migrate typescript third-party dependency to node_modules#32992
Open
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Open
refactor(@schematics/angular): migrate typescript third-party dependency to node_modules#32992alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
alan-agius4
force-pushed
the
typescript-third_party
branch
from
32360b7 to
0844943
Compare
…ncy to node_modules Relocates the typescript third-party dependency from `third_party/github.com/Microsoft/TypeScript` to `third_party/typescript`. This update changes the implementation to source the required TypeScript files directly from `node_modules` via a Bazel `genrule` instead of keeping them checked into the repository.
alan-agius4
force-pushed
the
typescript-third_party
branch
from
0844943 to
a9994b7
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the TypeScript dependency within the Angular schematics package, replacing a manually updated third-party directory with a Bazel genrule that pulls the required files directly from node_modules. However, the current implementation will cause a Bazel build error because a physical index.d.ts file exists in the same package where the genrule is configured to produce an output with the same name. Both review comments correctly identify this conflict and recommend removing the physical file.
alan-agius4
added
the
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relocates the typescript third-party dependency from
third_party/github.com/Microsoft/TypeScripttothird_party/typescript.This update changes the implementation to source the required TypeScript files directly from
node_modulesvia a Bazelgenruleinstead of keeping them checked into the repository.