refactor(@schematics/angular): remove explicit strict true in tsconfig template for TS6 compatibility#32993
Open
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Open
refactor(@schematics/angular): remove explicit strict true in tsconfig template for TS6 compatibility#32993alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
…g template for TS6 compatibility TypeScript 6 enables strict mode by default. This change updates the workspace schematic's `tsconfig.json` template to omit `"strict": true` when strict mode is desired (relying on the default), and explicitly sets `"strict": false` when it is disabled.
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the tsconfig.json template to remove the explicit "strict": true setting when strict mode is enabled, while adding an explicit "strict": false when it is disabled. Feedback suggests that removing the explicit strict setting relies on TypeScript 6.0 defaults and will silently disable strict mode for users on older versions. It is recommended to keep the "strict": true setting explicit to ensure consistent type safety across all supported TypeScript versions and to update the corresponding tests to reflect this requirement.
clydin
approved these changes
Apr 13, 2026
alan-agius4
added
action: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript 6 enables strict mode by default. This change updates the workspace schematic's
tsconfig.jsontemplate to omit"strict": truewhen strict mode is desired (relying on the default), and explicitly sets"strict": falsewhen it is disabled.