Keep agent runs alive when the workspace closes and make notices selectable - #15
Merged
Merged
Conversation
…ctable Clicking Miku to close the workspace was cancelling in-flight agent runs (store.stop() cancelled every session's run), surfacing "The agent run was stopped" errors mid-task. Closing now only stops the shells; runs keep streaming into their resident models and the transcript is waiting when the workspace reopens. Cancellation moves to terminate(), the app-quit path, where it still prevents orphaned subprocesses (thread deletion is unchanged). Error notices carry CLI diagnostics the user needs to copy out (e.g. codex version-mismatch errors), so notice and prompt text are now selectable like assistant messages. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015peMZyaHEmxDzyzNyhYeR5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
store.stop()cancelled every run, surfacing "The agent run was stopped" errors mid-task.terminate()app-quit path, which still prevents orphaned full-access subprocesses; thread deletion still cancels its run.Test plan
swift build -Xswiftc -warnings-as-errorscleanswift test -Xswiftc -warnings-as-errors: 207/207 (new: workspace-close keeps runs alive; app termination cancels runs)🤖 Generated with Claude Code
https://claude.ai/code/session_015peMZyaHEmxDzyzNyhYeR5