Skip to content

fix: explictly use docker runtime on minikube - #368

Merged
ttuffin merged 1 commit into
mainfrom
fix/ci-minikube-container-runtime
Sep 22, 2026
Merged

ttuffin merged 1 commit into
mainfrom
fix/ci-minikube-container-runtime

Conversation

@kaiokmo

@kaiokmo kaiokmo commented Sep 21, 2026

Copy link
Copy Markdown
Member

The latest ubuntu-latest runner image (20260831 -> 20260907) switched the default container runtime from docker to containerd, causing CI to break. We are now pinning minikube to use docker runtime.

Similar to ansible/galaxy-operator#291

Summary by CodeRabbit

  • Bug Fixes
    • Improved CI environment startup by explicitly selecting the Docker container runtime for Minikube-based checks.

The latest `ubuntu-latest` runner image (20260831 -> 20260907) switched
the default container runtime from docker to containerd, causing CI to
break. We are now pinning minikube to use docker runtime.
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 49839b3f-b3e3-4cbb-995a-d9b9019247ff

📥 Commits

Reviewing files that changed from the base of the PR and between a4646fc and feae7c0.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/pr.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Both CI workflows now pass --container-runtime=docker to minikube start. Existing Minikube startup options remain unchanged.

Changes

Minikube Runtime Configuration

Layer / File(s) Summary
Configure Docker runtime
.github/workflows/ci.yml, .github/workflows/pr.yml
Both Minikube startup commands explicitly select the Docker container runtime. The existing startup flags remain in place.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: explicitly selecting the Docker runtime for Minikube.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@ttuffin
ttuffin merged commit c71580e into main Sep 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants