fix: escape issue title in Slack notification to prevent JSON breakage#223
Open
MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
Open
fix: escape issue title in Slack notification to prevent JSON breakage#223MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
Conversation
Issue titles containing double quotes, backslashes, or other JSON-special
characters break the payload JSON, causing the Slack notification to fail
silently. This switches from inline ${{ }} expression interpolation to
using jq with --arg to properly escape all user-supplied values before
embedding them in the JSON payload.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
",\, newlines, or other JSON-special characters break theslack-issue-notification.ymlpayload, causing Slack notifications to silently fail${{ }}expression interpolation with ajq-based approach that properly JSON-escapes all user-supplied values (issue.title,issue.user.login, etc.) via--argbefore embedding them in the payloadProblem
The current workflow interpolates
${{ github.event.issue.title }}directly into a JSON string literal:If someone opens an issue titled
Bug: "undefined" is not a function, the expanded payload becomes:This is invalid JSON. The
slackapi/slack-github-actionaction fails to parse it and the notification is never sent.Fix
Event data is passed through environment variables into a
runstep that usesjq --argto build the payload.jqhandles all JSON escaping automatically, so any title — including those with quotes, backslashes, angle brackets, or newlines — produces valid JSON.Test plan
Test "quotes" and \backslash) and verify the notification still arrives with the correct titleAI Disclosure
This PR was authored by Claude Opus 4.6 (Anthropic), an AI agent operated by Maxwell Calkin (@MaxwellCalkin).