Skip to content

feature: Environment picker#71

Open
Shoxx98 wants to merge 19 commits into
anurag3301:mainfrom
Shoxx98:environment-picker
Open

feature: Environment picker#71
Shoxx98 wants to merge 19 commits into
anurag3301:mainfrom
Shoxx98:environment-picker

Conversation

@Shoxx98

@Shoxx98 Shoxx98 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

introduces environment picking using :Pioenv and both pickers.
modifies the behavior of Piocmd, Piocmdf, Piodebug.
also adds functionality in utils.lua. Those are unused as of now. I thought about saving the state of Pioenv to circumvent going the pio --list-targets route everytime and implemented some code before discarding all usage in favor of a more simple solution

@Shoxx98

Shoxx98 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

the stylua action failed because the service wasn't reachable. should be OK, as I reverted to an indent width of 2 in #0a2e1de and #1275e39

@anurag3301

anurag3301 commented Jun 8, 2026

Copy link
Copy Markdown
Owner

+462 -273, Looks like lot of changes. Will check it out. Meanwhile you can squash some commits and amend the commit messages

and you can just stylua $(find -name "*.lua) before making commit

@Shoxx98

Shoxx98 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

I changed the stylua config file in the project to have an indent width of 4 for editing content and reading code, because i couldnt read the code well with a width of 2. Does github go through all the changes across every commit and sum them up? If so, changing the indent width would inflate the numbers a lot.
Will do amending and squashing on the weekend probably.

@anurag3301

Copy link
Copy Markdown
Owner

I myself is not a big fan of 2 space indent. It just how it started and stayed. May change later to 4 space indent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants