fix(helm): keep install port aligned with service port#1522
Merged
LinkinStars merged 1 commit intoapache:devfrom May 8, 2026
Merged
fix(helm): keep install port aligned with service port#1522LinkinStars merged 1 commit intoapache:devfrom
LinkinStars merged 1 commit intoapache:devfrom
Conversation
Signed-off-by: Tian Teng <tian.teng@emerson.com>
Herrtian
force-pushed
the
fix-helm-install-port
branch
from
687bf29 to
54d0d76
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1438.
This keeps the chart's app-side port config aligned with
service.port. If the user hasn't already set them, the chart now derivesINSTALL_PORT,SITE_ADDR, andSWAGGER_ADDRESS_PORTfrom the service port, while explicit env values still win.Tested:
helm lint ./chartshelm template answer ./charts --set service.port=8080