Skip to content

chore: Replace dtolnay/rust-toolchain with rustup#108

Merged
kou merged 2 commits into
apache:mainfrom
Benjamin-Philip:bp/setup-rust
Jul 21, 2026
Merged

chore: Replace dtolnay/rust-toolchain with rustup#108
kou merged 2 commits into
apache:mainfrom
Benjamin-Philip:bp/setup-rust

Conversation

@Benjamin-Philip

Copy link
Copy Markdown
Collaborator

What issue does this PR close?

Closes #107.

The dtolnay/rust-toolchain has been causing many problems because of its
non-standard release practices, breaking Dependabot updates as well as the CI.
See the issue for more context.

What's Changed

A rust-toolchain.toml file has been added detailing exactly what we need. The
necessary rust compiler and components are now installed via a rustup toolchain install. This is more in line with the process in the arrow-rs project.

Copilot AI review requested due to automatic review settings July 20, 2026 15:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

Preview URL: https://Benjamin-Philip.github.io/arrow-erlang-1

If the preview URL doesn't work, you may have forgotten to configure your fork repository for preview.
See https://github.com/apache/arrow-erlang/blob/main/CONTRIBUTING.md#forks for instructions on how to configure.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add our license header?

@Benjamin-Philip
Benjamin-Philip requested review from Copilot and kou July 21, 2026 02:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 49e8e77 into apache:main Jul 21, 2026
11 checks passed
@Benjamin-Philip
Benjamin-Philip deleted the bp/setup-rust branch July 21, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace dtolnay/rust-toolchain with rustup

3 participants