feat(ipc): add dictionary batch write support - #928
Open
rustyconover wants to merge 11 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
==========================================
+ Coverage 79.30% 79.40% +0.10%
==========================================
Files 106 106
Lines 16223 16397 +174
Branches 1882 1942 +60
==========================================
+ Hits 12865 13020 +155
+ Misses 2177 2151 -26
- Partials 1181 1226 +45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rustyconover
force-pushed
the
fix/dictionary-batch-message-metadata
branch
from
September 2, 2026 14:08
0e55dbe to
de091e0
Compare
paleolimbot
reviewed
Sep 2, 2026
paleolimbot
left a comment
Member
There was a problem hiding this comment.
Thank you for this!
I will take a closer look in the next few days, but can I ask that the delta dictionary and/or appender piece be separated from the IPC write piece? All three are independently useful and I think it will be a smoother process if they're PRed separately as well.
Contributor
Author
|
Yep I'll break them out! Rusty |
rustyconover
force-pushed
the
fix/dictionary-batch-message-metadata
branch
from
September 2, 2026 18:12
de091e0 to
8db5007
Compare
Contributor
Author
|
Split completed as requested:
The original full branch is preserved as |
rustyconover
force-pushed
the
fix/dictionary-batch-message-metadata
branch
from
September 2, 2026 18:13
8db5007 to
0951095
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This builds on and is intended to supersede #926. Its original commit is retained as the first commit here, preserving authorship and credit to @niekverw.
The generic array-view appender has been extracted to #930. Dictionary-delta decoding is prepared on a separate branch and will be submitted after #930 merges so its diff contains only decoder work. Automatic append-only delta emission is intentionally no longer part of this PR.
IPC behavior
Streams emit full DictionaryBatch replacements when dictionary values change and advertise
DICTIONARY_REPLACEMENTin the schema. Files reject dictionary changes through the high-level array-stream writer. The low-levelArrowIpcWriterWriteDictionaryBatch()API can still encode explicitly requested delta batches and records their blocks in footer order.Validation