Fix Variant time microsecond JSON formatting#10173
Merged
Jefffrey merged 1 commit intoJun 22, 2026
Merged
Conversation
Jefffrey
approved these changes
Jun 22, 2026
Contributor
|
thanks @fallintoplace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This updates Variant
TimeJSON formatting to trim only trailing zeros from fractional microseconds.Why
The previous formatter used
trim_matches('0'), which removed leading zeros as well as trailing zeros. That could change values like.010010into.1001during JSON serialization.Validation
cargo fmt --package parquet-variant-jsoncargo test -p parquet-variant-json test_time_to_json