BIGTOP-4528. Restore conf-select removed by BIGTOP-4063#1388
Open
eubnara wants to merge 1 commit intoapache:masterfrom
Open
BIGTOP-4528. Restore conf-select removed by BIGTOP-4063#1388eubnara wants to merge 1 commit intoapache:masterfrom
eubnara wants to merge 1 commit intoapache:masterfrom
Conversation
Author
|
@timyuer @sekikn @JiaLiangC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Restore
conf-selectthat was unintentionally removed in BIGTOP-4063(#1236, "Adapt bigtop-select to Python 3"). The PR was meant to port the
script to Python 3 but deleted it instead.
The script is still referenced by Ambari's BIGTOP stack:
stacks/BIGTOP/*/properties/stack_tools.jsonpointsconf_selectorat/usr/lib/bigtop-select/conf-select.ambari-common'sresource_management.libraries.functions.conf_selectinvokes that path during stack-upgrade and config patching, and 30+
service scripts (HDFS, YARN, HBASE, HIVE, KAFKA, SPARK, FLINK, LIVY,
TEZ, ZEPPELIN, ZOOKEEPER, ALLUXIO, RANGER_KMS, ...) depend on it.
Changes:
conf-selectwith#!/usr/bin/env python3(content otherwiseidentical to the pre-BIGTOP-4063 version; already Python 3 compatible).
CONF_SELECTOR=conf-selectand itsinstallline ininstall_select.sh.Source3: conf-selectand its%prepinstall line inbigtop-select.spec.How was this patch tested?
python3 -m py_compile bigtop-packages/src/common/bigtop-select/conf-selectFor code changes: