[CALCITE-7595] Support FILTER clause with window functions#5019
Open
xuzifu666 wants to merge 4 commits into
Open
[CALCITE-7595] Support FILTER clause with window functions#5019xuzifu666 wants to merge 4 commits into
xuzifu666 wants to merge 4 commits into
Conversation
mihaibudiu
reviewed
Jun 13, 2026
mihaibudiu
left a comment
mihaibudiu
left a comment
Contributor
There was a problem hiding this comment.
Where is the documentation about the new grammar and its semantics?
| # [CALCITE-6442] Support FILTER clause with window functions | ||
|
|
||
| # Test 1: FILTER with OVER on COUNT | ||
| select empno, deptno, |
Contributor
There was a problem hiding this comment.
How are these validated?
Member
Author
There was a problem hiding this comment.
Thanks for the reminder, I still need to investigate this.
Member
Author
There was a problem hiding this comment.
I improved the tests，can refer to this document: https://www.postgresql.org/docs/current/sql-expressions.html#SYNTAX-AGGREGATES
PostgreSQL test in： https://onecompiler.com/postgresql/44sbpn95k @mihaibudiu
Contributor
There was a problem hiding this comment.
You need to document the new grammar constructs in reference.md
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/CALCITE-7595