Reword micrometer shutdown-filters Javadoc to avoid mis-nested AsciiDoc - #1973
Merged
Merged
Conversation
The Javadoc of camel.metrics.log-metrics-on-shutdown-filters is copied into the generated starters/micrometer.adoc table. Its two `*` characters (`*` and `camel.exchanges.*`) pair up as AsciiDoc constrained bold across the monospace spans, so Asciidoctor emits <code>...<strong></code>. The website's HTML-to-Markdown step cannot recover from that nesting and skips the page, leaving starters/micrometer.md missing. Reword the sentence so only one `*` remains. A passthrough (+...+) is avoided because it would also show up literally in the Spring configuration-metadata tooltip. See apache/camel-website#1746 _Claude Code on behalf of Adriano Machado (@ammachado)_ _This was generated by an AI agent and may contain inaccuracies. Please verify before relying on it._
davsclaus
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
starters/micrometerpage (nextand4.22.x) is one of the 35 documentation pages with no.mdtwin on the website, see apache/camel-website#1746.The Javadoc of
camel.metrics.log-metrics-on-shutdown-filtersis copied into the generated option table ofdocs/spring-boot/modules/ROOT/pages/starters/micrometer.adoc. It contains two*characters (`*`and`camel.exchanges.*`), which Asciidoctor pairs as constrained bold across the monospace spans:Browsers tolerate this, but the website's HTML-to-Markdown step (
node-html-parser) losesarticle.docand skips the page.Change
Reword the Javadoc so only one
*remains in the table cell:A
+...+passthrough is avoided on purpose: the same text ends up in the Spring configuration-metadata tooltip, where the+signs would show literally.micrometer.jsonandmicrometer.adocare regenerated by building the starter (-pl components-starter/camel-micrometer-starter -am), not edited by hand.Verification
Rendered the generated
micrometer.adocwith Asciidoctor.js and parsed it with the website'snode-html-parser:valid()article.docfound<code>..<strong></code>The example still renders as
<code>camel.exchanges.*</code>. Module tests were not run: the change touches a Javadoc comment and generated docs only.The same fix for
camel-spring-boot-4.22.xis in #1974. The option does not exist on 4.18.x or 4.14.x.🤖 Generated with Claude Code on behalf of Adriano Machado (@ammachado)
This was generated by an AI agent and may contain inaccuracies. Please verify before relying on it.