-
Notifications
You must be signed in to change notification settings - Fork 5.2k
CAMEL-23761: Add SqsProducerDelayedQueueIT for the delayed queue pattern #26395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
66 changes: 66 additions & 0 deletions
66
.../test/java/org/apache/camel/component/aws2/sqs/integration/SqsProducerDelayedQueueIT.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.camel.component.aws2.sqs.integration; | ||
|
|
||
| import java.time.Duration; | ||
| import java.time.Instant; | ||
| import java.util.UUID; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import org.awaitility.Awaitility; | ||
| import org.junit.jupiter.api.Test; | ||
| import software.amazon.awssdk.services.sqs.model.ListQueuesResponse; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| class SqsProducerDelayedQueueIT extends Aws2SQSBaseTest { | ||
|
|
||
| @Test | ||
| void delayedQueue() throws Exception { | ||
| int delay = 20; | ||
| String delayedQueueName = sharedNameGenerator.getName() + "_delayed"; | ||
| Instant start = Instant.now(); | ||
|
|
||
| // Create the delayed queue via autoCreateQueue | ||
| template.requestBody( | ||
| String.format( | ||
| "aws2-sqs://%s?autoCreateQueue=true&delayQueue=true&delaySeconds=%d&operation=listQueues", | ||
| delayedQueueName, delay), | ||
| null, ListQueuesResponse.class); | ||
|
|
||
| // Send a message to the delayed queue | ||
| String msg = "sqs" + UUID.randomUUID().toString().replace("-", ""); | ||
| template.requestBody("aws2-sqs://" + delayedQueueName, msg, String.class); | ||
|
|
||
| // Poll until the message is received; use visibilityTimeout (per-request) instead of | ||
| // defaultVisibilityTimeout (queue-level attribute) to avoid overwriting the queue's | ||
| // DELAY_SECONDS attribute via SetQueueAttributes. | ||
| Awaitility.await().pollInterval(1, TimeUnit.SECONDS).atMost(120, TimeUnit.SECONDS) | ||
| .until(() -> msg.equals(receiveMessageFromQueue(delayedQueueName))); | ||
|
|
||
| assertThat(Duration.between(start, Instant.now()).getSeconds()).isGreaterThanOrEqualTo(delay); | ||
| } | ||
|
|
||
| private String receiveMessageFromQueue(String queueName) { | ||
| // visibilityTimeout=0 sets the per-request visibility timeout in ReceiveMessage, | ||
| // which does not call SetQueueAttributes and therefore does not disturb DELAY_SECONDS. | ||
| return consumer.receiveBody( | ||
| String.format("aws2-sqs://%s?deleteAfterRead=false&deleteIfFiltered=false&visibilityTimeout=0", | ||
| queueName), | ||
| 10000, String.class); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Naming convention: All 12 existing tests in this package use the
*LocalstackITsuffix (SqsConsumerLocalstackIT,SqsProducerAutoCreateQueueLocalstackIT, etc.). Consider renaming toSqsProducerDelayedQueueLocalstackITfor consistency.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localstack is no more used, it would be better to rename the other tests