Skip to content

Reject out-of-range values in LongLocaleConverter (1.X)#407

Merged
garydgregory merged 2 commits into
apache:1.Xfrom
rootvector2:longlocaleconverter-range-1.x
Jul 2, 2026
Merged

Reject out-of-range values in LongLocaleConverter (1.X)#407
garydgregory merged 2 commits into
apache:1.Xfrom
rootvector2:longlocaleconverter-range-1.x

Conversation

@rootvector2

Copy link
Copy Markdown
Contributor

Port of #406 to the 1.X branch.

LongLocaleConverter.parse narrows the parsed number with result.longValue() and never range-checks it, so a value beyond long range like 99999999999999999999 is silently clamped to Long.MAX_VALUE instead of rejected: DecimalFormat returns it as a Double (the converter does not set parseBigDecimal) and Double.longValue() saturates.

The sibling narrowing locale converters IntegerLocaleConverter, ByteLocaleConverter, ShortLocaleConverter and FloatLocaleConverter already reject out-of-range input, so LongLocaleConverter gets the same bounds check before narrowing. Found while auditing the locale converter family against those sibling checks.

Added a regression test to LongLocaleConverterTest; it fails without the runtime change (99999999999999999999 comes back as 9223372036854775807). mvn test -Dtest='*LocaleConverterTest' is green (107 tests).

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

LongLocaleConverter.parse narrows the parsed number with longValue()
and never range-checks it, so a value beyond long range like
99999999999999999999 is silently clamped to Long.MAX_VALUE instead of
rejected: DecimalFormat returns it as a Double (the converter does not
set parseBigDecimal) and Double.longValue() saturates. Add the same
bounds check the sibling IntegerLocaleConverter, ByteLocaleConverter,
ShortLocaleConverter and FloatLocaleConverter already apply before
narrowing.

Signed-off-by: Naveed Khan <dxbnaveed.k@gmail.com>

@garydgregory garydgregory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rootvector2
Please use assertThrows.

@garydgregory

Copy link
Copy Markdown
Member

@rootvector2 ping ;)

Signed-off-by: Naveed Khan <dxbnaveed.k@gmail.com>
@rootvector2

Copy link
Copy Markdown
Contributor Author

Done, switched the two out-of-range cases to assertThrows.

@garydgregory garydgregory merged commit 89d299f into apache:1.X Jul 2, 2026
8 checks passed
@garydgregory

Copy link
Copy Markdown
Member

Merged 🚀 TY! Would you have a look at these warnings please?

Jul 02, 2026 3:45:42 PM org.junit.platform.launcher.core.DiscoveryIssueNotifier logIssues
WARNING: TestEngine with ID 'junit-jupiter' encountered 3 non-critical issues during test discovery:

(1) [WARNING] Inner class 'org.apache.commons.collections4.map.AbstractMapTest$TestMapEntrySet' looks like it was intended to be a test class but will not be executed. It must be static or annotated with @Nested.
    Source: ClassSource [className = 'org.apache.commons.collections4.map.AbstractMapTest$TestMapEntrySet', filePosition = null]
            at org.apache.commons.collections4.map.AbstractMapTest$TestMapEntrySet.<no-method>(SourceFile:0)

(2) [WARNING] Inner class 'org.apache.commons.collections4.map.AbstractMapTest$TestMapKeySet' looks like it was intended to be a test class but will not be executed. It must be static or annotated with @Nested.
    Source: ClassSource [className = 'org.apache.commons.collections4.map.AbstractMapTest$TestMapKeySet', filePosition = null]
            at org.apache.commons.collections4.map.AbstractMapTest$TestMapKeySet.<no-method>(SourceFile:0)

(3) [WARNING] Inner class 'org.apache.commons.collections4.map.AbstractMapTest$TestMapValues' looks like it was intended to be a test class but will not be executed. It must be static or annotated with @Nested.
    Source: ClassSource [className = 'org.apache.commons.collections4.map.AbstractMapTest$TestMapValues', filePosition = null]
            at org.apache.commons.collections4.map.AbstractMapTest$TestMapValues.<no-method>(SourceFile:0)

TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants