Fix silent int overflow in Fraction.getFraction(double)#1717
Merged
garydgregory merged 1 commit intoJun 19, 2026
Conversation
garydgregory
added a commit
that referenced
this pull request
Jun 19, 2026
Member
|
I checked the new assertions fail without the TY! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.Repro:
Fraction.getFraction(2147483646.5)returns-3/2andgetFraction(1073741824.5)returns-2147483647/2.Cause: the result numerator is rebuilt as
numer0 + wholeNumber * denom0inint.wholeNumbercan be up toInteger.MAX_VALUEanddenom0is the convergent denominator (> 1for any non-integer value), so the product overflows and wraps. The value is not representable as anint/intFraction, so the documentedArithmeticExceptionshould be thrown instead of returning a wrong reduced fraction.Fix: route the numerator reconstruction through the existing
mulAndCheckandMath.addExact, so the overflow is rejected the same way thevalue > Integer.MAX_VALUEguard already rejects out-of-range input. Whole numbers (wheredenom0 == 1) and all in-range values are unaffected.